Improve block state registry patch#13
Open
Meldexun wants to merge 2 commits intoFermiumModding:mainfrom
Open
Conversation
Unnecessary memory usage when not having a lot of mods. Growing a list is fast enough anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to the block state registry identity patch.
Initial size of 65k does not have any significant benefit. At most you are going to save a few milliseconds of startup time. Better use a conservative initial capacity to avoid potential issues.
Store block state IDs in block state instances directly. Improves performance by avoiding two array list accesses and auto-unboxing.